.. _important: https://moira.readthedocs.io/en/release-2.5/release_notes/2_4_0.html
.. _upgrading: https://moira.readthedocs.io/en/release-2.5/release_notes/2_5_0.html#upgrading
.. |incompatible changes| replace:: incompatible changes
.. _incompatible changes: https://moira.readthedocs.io/en/release-2.5/release_notes/2_5_0.html#incompatible-changes
.. |version 2.4| replace:: version 2.4
.. _version 2.4: https://github.com/moira-alert/moira/releases/tag/v2.4.0
.. |WEB UI configuration guide| replace:: WEB UI configuration guide
.. _WEB UI configuration guide: https://moira.readthedocs.io/en/release-2.5/installation/configuration.html#web-ui
.. |default WEB UI configuration| replace:: default WEB UI configuration
.. _default WEB UI configuration: https://github.com/moira-alert/moira/blob/b8523885f003fceeefe98ca30be2b42d70032794/pkg/api/web.json
.. |email template| replace:: email template
.. _email template: https://moira.readthedocs.io/en/release-2.5/installation/configuration.html#email-template
.. _documantation: https://moira.readthedocs.io/en/release-2.5/installation/webhooks_scripts.html


2.5.0
=====

Upgrading
---------

.. warning::
   This release is not compatible with Redis version below 3.2, please upgrade your Redis instance.

.. warning::
   It is not possible to upgrade from Moira 2.2 to Moira 2.5 directly. To upgrade Moira from version 2.2 or older to 2.5, please first run moira-cli |version 2.4|_ (see :ref:`important <moira-cli-2-4-0>` note).

Please update your web configuration according to the following rules:

- Add ``label`` (new required field). You can see default type and label field mappings in |default WEB UI configuration|_.
- Rename ``title`` to ``placeholder``.

See |WEB UI configuration guide|_ for more information.


Incompatible changes
--------------------

- Removed deprecated method ``PUT trigger/{{triggerId}}/maintenance``. Use ``PUT trigger/{{triggerId}}/setMaintenance`` instead (request body has not changed).
- Removed deprecated version 2.2 related conversion code. Now if you want to upgrade Moira from version 2.2 or older use moira-cli |version 2.4|_ (see important_ note).
- Fixed contact types configuration. It was hardcoded in the web UI, and now it is configurable via config file (as it should have been originally).
- Renamed the ``title`` field to more semantically correct ``placeholder`` in web UI config.
- Added a new required ``label`` field to web UI config, which is used as a contact label in web UI instead of ``type``.
- Removed ``ERROR_VALUE`` and ``WARN_VALUE`` as valid variables in expression. Old triggers with these variables will still work, but you can not update these triggers until you delete ``ERROR_VALUE`` and ``WARN_VALUE`` variables from the expression.
- Dropped support for all old browsers. Only last 2 major versions of Chrome, Firefox, Safari (all mobile and desktop) and Edge (only desktop) are supported.

New features
------------

- Added Graphite tags support `#142 <https://github.com/moira-alert/moira/issues/142>`_.
- Reworked trigger search input control in web UI. Fulltext search is now available, as long as the old tag filters `#185 <https://github.com/moira-alert/moira/issues/185>`_.
- Added Webhook sender `#123 <https://github.com/moira-alert/moira/issues/123>`_. For more info see documantation_.
- Added information who and when turned on maintenance mode. You can see it as a hint in web UI near the metric, and in metric alert message `#192 <https://github.com/moira-alert/moira/issues/192>`_.
- Added a meaningful title to all Moira web pages `#177 <https://github.com/moira-alert/moira/issues/177>`_.
- Added environment variable that customizes api URL path for web UI Docker image `#173 <https://github.com/moira-alert/moira/issues/173>`_.
- Added new variables to script sender. Variable ${trigger_name} is now deprecated, removed from documentation and will be removed in the future versions of Moira `#228 <https://github.com/moira-alert/moira/issues/228>`_. For more information about new variables and script configuration see documantation_.


Bug fixes and improvements
--------------------------

- Limited connection count in Redis connection pool, added a separate pool for remote locks, added ConnectionsLimit config field in Redis configuration `#163 <https://github.com/moira-alert/moira/issues/163>`_.
- Prohibited saving trigger with both ``expression`` and ``warn_value`` + ``error_value``. If you set both of these fields, API will return 400 status code. Web UI saves only fields that are displayed in the open tab (simple or advanced mode) `#172 <https://github.com/moira-alert/moira/issues/172>`_.
- Fixed handling incoming metrics with Windows-style line breaks (/r/n) `#268 <https://github.com/moira-alert/moira/pull/268>`_.
- Fixed checking of triggers that do not have any metrics stored in remote or local storage `#166 <https://github.com/moira-alert/moira/issues/166>`_.
- Fixed execution of self-checks: do it only once, regardless of how many notifier instances are running `#186 <https://github.com/moira-alert/moira/issues/186>`_.
- Fixed response code on invalid requests to update or create trigger (was 500, now 400) `#323 <https://github.com/moira-alert/moira/pull/323>`_.
- Combined telegram alert and plot in one message `#248 <https://github.com/moira-alert/moira/pull/248>`_.
- Added icons in Slack notifications `#180 <https://github.com/moira-alert/moira/issues/180>`_. See more: :ref:`slack-icons`.
- Got rid of old ugly mail template, now we use only new |email template|_. `#181 <https://github.com/moira-alert/moira/issues/181>`_.
- Fixed bug that turned old pseudo-tags ``ERROR`` ``DEGRADATION`` ``HIGH DEGRADATION`` to subscription settings checkboxes `#184 <https://github.com/moira-alert/moira/issues/184>`_.
- Fixed advanced schedule in subscriptions `#162 <https://github.com/moira-alert/moira/pull/162>`_.
- Fixed multibyte splitting bug in graph titles `#179 <https://github.com/moira-alert/moira/issues/179>`_.
- Fixed sending a message "This metric changed its state..." if a state does not change during maintenance interval `#328 <https://github.com/moira-alert/moira/issues/328>`_.
- Removed useless broken links in test and self-state notifications `#178 <https://github.com/moira-alert/moira/issues/178>`_.
- Fixed symbols counting bug in telegram messages `#248 <https://github.com/moira-alert/moira/pull/248>`_.
- Changed mobile detection logic from "get window width" to "parse user agent and detect mobile browser" `#218 <https://github.com/moira-alert/web2.0/pull/218>`_.
- Fixed 500 status code then trying to update subscription if one of the subscribed triggers was removed `#271 <https://github.com/moira-alert/moira/pull/271>`_.
- Properly encoded parameters that are passed in a web to API requests `#174 <https://github.com/moira-alert/moira/issues/174>`_.
- Fixed layout with long words or URLs in name and description on the trigger web page `#176 <https://github.com/moira-alert/moira/issues/176>`_.
- Fixed showing tags that exist in the user local browser storage, but don't exist in server-side `#175 <https://github.com/moira-alert/moira/issues/175>`_.
- Fixed external loader on non-existing trigger page in a mobile version of the web `#168 <https://github.com/moira-alert/moira/issues/168>`_.
- Removed cancel button and restyled delete button in subscription modal `#221 <https://github.com/moira-alert/moira/issues/221>`_.
- Prohibited creating simple mode trigger with several targets via API `#171 <https://github.com/moira-alert/moira/issues/171>`_.
- Fixed data source toggle that was missing from simple edit trigger mode `#236 <https://github.com/moira-alert/moira/issues/297>`_.
- Fixed rising/falling mode selector when switching between simple and advanced modes `#172 <https://github.com/moira-alert/moira/issues/172>`_.
- Limited Twilio SMS sender to 5 events per SMS `#237 <https://github.com/moira-alert/moira/pull/247>`_.
- Fixed Pushover message priority calculation when sending over five events `#237 <https://github.com/moira-alert/moira/pull/247>`_.
- Added contact type icon in choose subscription contact combobox `#219 <https://github.com/moira-alert/moira/issues/219>`_.
- Changed remove subscription contact icon `#220 <https://github.com/moira-alert/moira/issues/220>`_.
- Improved plotting conditions to render non-empty timeseries only `#197 <https://github.com/moira-alert/moira/issues/197>`_.
- Upgraded NPM dependencies for security reasons `#194 <https://github.com/moira-alert/moira/issues/194>`_.
- Added log message describing the reason why self-state monitor disabled notifications `#323 <https://github.com/moira-alert/moira/pull/323>`_.